browserup / browserup-proxy

BrowserUp Proxy is a free utility to watch, test, and manipulate web application network traffic and performance.
https://browserup.com
Apache License 2.0
164 stars 41 forks source link

Adopt appropriate terminology: AllowList and BlockList #281

Closed johnjbarton closed 3 years ago

johnjbarton commented 4 years ago

Your API should use feature-oriented nouns like 'skip' or 'allow' and phase out antiquated non-descriptive color based names: https://github.com/browserup/browserup-proxy/search?q=blacklist&unscoped_q=blacklist

Obviously this will require adding the API and deprecating the old usage.

ericbeland commented 4 years ago

This should be workable. "Skip" isn't clear to me whether it skips the proxy, or skips making the request. We will use "Allow" list and "Block" list.

The next major release will have some breaking changes to the API as we're moving to wrap mitmproxy in place of littleproxy, so we will ship this at that point.

ericbeland commented 3 years ago

PR merged here: https://github.com/browserup/browserup-proxy/pull/337