search

browserup / browserup-proxy

BrowserUp Proxy is a free utility to watch, test, and manipulate web application network traffic and performance.
https://browserup.com
Apache License 2.0
164 stars 41 forks source link

Add ability to create Selenium proxy from hostname and port #318

Closed valfirst closed 3 years ago

ericbeland commented 3 years ago

Hi @valfirst, I haven't had a chance to look at this yet, but could you add some background on your use case and needs into the PR for when we review? Any context is helpful. Best,

Eric

valfirst commented 3 years ago

Hi @ericbeland, we have Docker-based environment (containers with browsers), so we can't use InetSocketAddress to configure Selenium proxy, because the address like host.docker.internal is reachable only from containers. Having the changes from PR we can use simple String to configure the host.

For now we are forced to create Selenium proxy in the ugly way:

https://github.com/vividus-framework/vividus/blob/88df73eefb32b78fab6bd3e736eddbb3b114b5d4/vividus-extension-selenium/src/main/java/org/vividus/proxy/Proxy.java#L116-L131