browserutils / kooky

Go code to read cookies from browser cookie stores.
MIT License
210 stars 41 forks source link

firefox: add support for new db format without "baseDomain" column #15

Closed srlehn closed 4 years ago

srlehn commented 4 years ago

Add support for new db format without "baseDomain" column and with new "rawSameSite" column. Domain is now derived from the host column with the new import "github.com/bobesa/go-domain-util/domainutil".

old layout on the left: ffdb

srlehn commented 4 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1609176

https://phabricator.services.mozilla.com/D60464

srlehn commented 4 years ago

go.mod is not updated

zellyn commented 4 years ago

Thanks for your PRs: very helpful!

srlehn commented 4 years ago

Both PRs did add some dependencies though. go.mod needs now an update with go get -u ./.... I do hope that the formats of both browsers stays the same now... for a while at least. It would probably also be better if we could address the columns by name and not the index? Do you perhaps know if github.com/go-sqlite/sqlite3 provides this? For #6 we probably can use the security tool for querying the password (not setting) but I can't test this without a macos machine.

zellyn commented 4 years ago

Updated go.mod and merged. Thanks!