search

browsh-org / browsh

A fully-modern text-based browser, rendering to TTY and browsers
https://www.brow.sh
GNU Lesser General Public License v2.1
17.08k stars 417 forks source link

Better error message to know if browsh or firefox is segfaulting. #525

Open gl-yziquel opened 5 months ago

gl-yziquel commented 5 months ago

Hello.

I build browsh from source and git HEAD. And also firefox. So it's not entirely surprising that I get segfaults. However, I here wish to complain about the error message system. I get:

panic: runtime error: invalid memory address or nil pointer dereference
                                                                       [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x4cc50e]

                                                                                                                                             goroutine 9 [running]:
                                                                                                                                                                   os.(*Process).signal(0x4?, {0x968268?, 0xb75058?})
                                                                                                                                                                                                                        /home/mini-me/.goenv/v

ni-me/.goenv/versions/1.22.3/src/os/exec.go:140
                                               os.(*Process).kill(...)
                                                                        /home/mini-me/.goenv/versions/1.22.3/src/os/exec_posix.go:67
                                                                                                                                    os.(*Process).Kill(...)
                                                                                                                                                                /home/mini-me/.goenv/versions/1.22.3/src/os/exec.go:125
                                                                                                                                                                                                                       github.com/browsh-org/b

ard/hephaestus/browsh-master/interfacer/src/browsh/firefox.go:93 +0x5fa
                                                                       created by github.com/browsh-org/browsh/interfacer/src/browsh.setupFirefox in goroutine 1
                                                                                                                                                                        /home/mini-me/home/backyard/hephaestus/browsh-master/interfacer/src/br

So. 1. The layout is problematic. 2. It's really hard to tell, at first glance whether it is browsh or firefox that is segfaulting.

Could error handling and reporting be improved ?

x66ccff commented 2 months ago

i got the same error, i install by using .deb , 1.8.0 and 1.8.2 both run into this. Can not figure out why.

ebenoist commented 1 week ago

Same here on Ununtu 24.04.1

[~/.config]❥ neofetch
            .-/+oossssoo+/-.               erik@bestia
        `:+ssssssssssssssssss+:`           -----------
      -+ssssssssssssssssssyyssss+-         OS: Ubuntu 24.04.1 LTS x86_64
    .ossssssssssssssssssdMMMNysssso.       Host: B760 DS3H AC DDR4 -CF
   /ssssssssssshdmmNNmmyNMMMMhssssss/      Kernel: 6.8.0-48-generic
  +ssssssssshmydMMMMMMMNddddyssssssss+     Uptime: 3 days, 2 hours, 28 mins
 /sssssssshNMMMyhhyyyyhmNMMMNhssssssss/    Packages: 2984 (dpkg), 15 (flatpak), 23 (snap)
.ssssssssdMMMNhsssssssssshNMMMdssssssss.   Shell: bash 5.2.21
+sssshhhyNMMNyssssssssssssyNMMMysssssss+   Resolution: 3840x2160, 3200x5120
ossyNMMMNyMMhsssssssssssssshmmmhssssssso   DE: GNOME 46.0
ossyNMMMNyMMhsssssssssssssshmmmhssssssso   WM: Mutter
+sssshhhyNMMNyssssssssssssyNMMMysssssss+   WM Theme: Adwaita
.ssssssssdMMMNhsssssssssshNMMMdssssssss.   Theme: Yaru [GTK2/3]
 /sssssssshNMMMyhhyyyyhdNMMMNhssssssss/    Icons: Yaru [GTK2/3]
  +sssssssssdmydMMMMMMMMddddyssssssss+     Terminal: zellij
   /ssssssssssshdmNNNNmyNMMMMhssssss/      CPU: 13th Gen Intel i7-13700K (24) @ 5.300GHz
    .ossssssssssssssssssdMMMNysssso.       GPU: Intel Raptor Lake-S GT1 [UHD Graphics 770]
      -+sssssssssssssssssyyyssss+-         GPU: AMD ATI Radeon RX 470/480/570/570X/580/580X/590
        `:+ssssssssssssssssss+:`           GPU: NVIDIA GeForce RTX 3060
            .-/+oossssoo+/-.               Memory: 13766MiB / 128579MiB