search

brpaz / ulauncher-file-search

Quick Search files and directories from Ulauncher
MIT License
72 stars 35 forks source link

exclude wine directory from search (issue#2) #3

Closed dalanicolai closed 5 years ago

dalanicolai commented 5 years ago

I changed the code to solve issue #2 for myself (I opened the issue). I guess issue #1 can also be solved in a similar way

friday commented 5 years ago

This explains the problem: https://github.com/sharkdp/fd/issues/378

While this PR fixes the issue for me, I would remove the -L flag (follow symlinks) instead. It's potentially dangerous, and not super useful imo. Also could limit resources with --threads 1, ionice -c 3 and/or using a timeout so that it won't crash the system if something goes wrong, but this is up to @brpaz.

brpaz commented 5 years ago

This extension is just a wrapper around "fd". Any configurations regarding ignore files can be configured at system level using .gitignore or .fdignore files like explained in the fd documentation.

We shouldn't hardcode any ignored directory like this. I might want to be able to search on .wine dir for some reason. What we could do is to make the list of ignored files configurable in the plugin settings. We could add some sane default values there like the .wine or other system folders.

If you or anyone else want to contribute with that feature, fine. Otherwise I might implement it but its not a priority right now.

friday commented 5 years ago

~/.wine/dosdevices/z: is the culprit, and hence may be a better candidate for a default ignore list (it's just a link to "/"). You would still be able to find content in .wine