search

brrd / abricotine

Markdown editor with inline preview
GNU General Public License v3.0
2.63k stars 159 forks source link

Load hunspell dictionaries in addition to OS dictionaries #134

Closed zommuter closed 2 years ago

zommuter commented 7 years ago

While I have the directories de_DE, en_US, es, fr_FR in %appdata%\Abricotine\app\dict, Abricotine instead let's me choose between three local variants of German (de_DE, de_CH, de_AT) instead:

abricotine-spellcheck

Any idea what went wrong? My Windows locale is indeed de_CH if that matters.

brrd commented 7 years ago

This is the expected behavior.

Check the documentation: https://github.com/brrd/Abricotine/blob/master/docs/configuration.md#spell-checker-dictionaries

When the OS includes native dictionaries then hunspell dictionaries are ignored and Abricotine loads system dictionaries instead. If you need another language, just install it from your OS preferences.

zommuter commented 7 years ago

@brrd Thanks. That seems a bit counter-intuitive at first, would it be possible to use OS settings and then additionally consider the provided hunspell files (overriding OS settings for duplicates)? I don't actually know what kind of Windows setting provides those languages, the only MS thing I have installed is Office but that also has en_US available, so I don't have an idea which "OS preferences" the documentation refers to. This could also be a problem for users without admin permissions I guess.

Great tool by the way 👍

brrd commented 7 years ago

On windows you can add dictionaries from the language settings in the control panel. This option is interesting because it makes dictionaries consistent among programs, which is especially useful when you add your own custom entries. But mixing the two behaviors is a good idea.

overriding OS settings for duplicates

I would override hunspell instead. We can maybe let the user choose with an option.

zommuter commented 7 years ago

@brrd An option for selecting the preferred data indeed sounds best, thanks for reconsidering.

I found the Windows 10 option now, that has the disadvantage that adding another language is coupled to adding its keyboard layout, which in turn means by default the keyboard combination left-ALT+left-SHIFT cycles through them, which may not be desired. Another reason for me to prefer the hunspell variant.

brrd commented 2 years ago

Abricotine 1.1 now uses nspell dictionaries on all platforms. See https://github.com/brrd/abricotine/blob/master/docs/configuration.md#spell-checker-dictionaries