nathanlesage
commented
4 years ago Just checked back on your awesome editor to see how it's going and immediately found this issue!
Concerning this:
On a ~100 lines document, this function takes more than 250ms to run, which freezes the editor each time CodeMirror "updates". This results in a jerky scrolling.
Yes, if you always perform that function it can be burdensome. What I found out is that what best works is to fire some events only during CodeMirror.on('cursorActivity'): https://github.com/Zettlr/Zettlr/blob/develop/source/renderer/zettlr-editor.js#L358
Here's how I recently implemented the background colors on codeblocks: https://github.com/Zettlr/Zettlr/blob/develop/source/renderer/assets/codemirror/zettlr-plugin-markdown-codeblock-classes.js
Not on update but on cursorActivity, because in fact the line classes are cached by CodeMirror and are applied automatically, you only need to (re)set them when the code actually changes! (P.S.: I'm completely unsure whether or not the operation helps or is just decoration …)
brrd
The editor encounters huge performance issues on scroll, obviously because of this event handler:
https://github.com/brrd/Abricotine/blob/63de38d54eb30d6f893f045dc698423397917556/app/renderer/cm-init.js#L160-L171
On a ~100 lines document, this function takes more than 250ms to run, which freezes the editor each time CodeMirror "updates". This results in a jerky scrolling.
Parsing threw the whole document line by line with
cm.eachLineand runninggetModeAt(which is very expensive) each time is a very bad design which should be avoided. Instead, empty lines in code blocks should be styled by using the markdown parser as expected.