search

brry / rdwd

download climate data from DWD (German Weather Service)
https://bookdown.org/brry/rdwd
72 stars 13 forks source link

dataDWD: should dbin default be TRUE? #20

Closed brry closed 3 years ago

brry commented 4 years ago

Consider the implications of setting the default call to download.file with wb=TRUE

https://bookdown.org/brry/rdwd/raster-data.html#binary-file-errors

adamhsparks commented 4 years ago

Saw this on the R-pkg-devel list.

Yes, you want to do this. Otherwise, it won't properly work on Windows as you've noted. It bit me in https://github.com/ropensci/GSODR as I use macOS or Linux and forgot to set this for binary downloads.