search

brry / rdwd

download climate data from DWD (German Weather Service)
https://bookdown.org/brry/rdwd
72 stars 13 forks source link

Several links to ftp://opendata.dwd.de in documentation fail #29

Closed tillschwoerer closed 3 years ago

tillschwoerer commented 3 years ago

Dear Berry,

I noticed that several links in your bookdown documentation of the package to the opendata platform of DWD are not working properly. The reason seems to be that urls have changed from ftp://opendata.dwd.de to https://opendata.dwd.de/

For instance in 1. Intro it must be https://opendata.dwd.de/climate_environment/CDC/Readme_intro_CDC_ftp.pdf rather than ftp://opendata.dwd.de/climate_environment/CDC/Readme_intro_CDC_ftp.pdf. The same applies also, e.g. to all the links provided in section 4 Available Datasets.

Best regards Till

brry commented 3 years ago

Hi Till,

thanks for reporting this! For me on Firefox, the FTP link opens just fine (although github markdown doesn't link to it): ftp://opendata.dwd.de/climate_environment/CDC/Readme_intro_CDC_ftp.pdf

when searching for Github markdown FTP, I found https://github.com/go-gitea/gitea/issues/8478#issuecomment-541369371 where @guillep2k writes that Google Chrome 82 won't support FTP anymore.

For Chrome users, I could add references to the html pages aditionally to the FTP pages.
In section 4 Available Datasets, I would have to replace all urls, as having two is not feasable there.

I need to think about this a bit more.
I generally like the look of the FTP interface better and it is where rdwd gets all the data by default...
On the other hand, I would like the website to be usable for all users...

brry commented 3 years ago

Firefox now also pulled the plug on FTP, so I'm replacing all ftp links with https throughout the package. The internal dwdbase, indexFTPetc will keep using FTP.