brson / miri

An experimental compiler from Rust to WebAssembly (inactive - do not use)
Apache License 2.0
209 stars 15 forks source link

Upgrade binaryen and fix some trans errors #48

Closed lqd closed 7 years ago

lqd commented 7 years ago

This upgrades binaryen since some of our debug/release validation behaviors have improved on master (and a bit of the handling around validation and tracing has been improved to investigate those differences).

This made our tests fail validation because of some seemingly invalid BinaryenDrops and BinaryenTeeLocals. I’m not exactly sure what the purpose behind those was, so I just removed the (I think) invalid ones creating the errors with our tests.

eholk commented 7 years ago

Thanks!