brson / rust-sdl

SDL bindings for Rust
MIT License
179 stars 52 forks source link

Fixes to deal with c_str / c_vec stabilization changes related to Rust R... #150

Closed pdovy closed 9 years ago

pdovy commented 9 years ago

...FC 494 now in the nightly.

This fixes a bunch of c_str related issues that popped up building against the latest nightly, which seem to be related to changes that got made as a result of RFC 494.

One thing I was not sure about was replacing the seemingly deprecated into_inner calls with as_ptr. The behavior isn't the same IIRC - Rust wouldn't clean up the memory for the former. That doesn't seem like correct behavior though, as the callee SDL methods are FFI calls into C methods that won't free the argument either.

lifthrasiir commented 9 years ago

Thank you!