search

brson / rust-sdl

SDL bindings for Rust
MIT License
179 stars 52 forks source link

Implement `img::load_img` (`IMG_Load` from `SDL_image`). #29

Closed dpc closed 11 years ago

dpc commented 11 years ago

Because life without transparent images is so boring...

AngryLawyer commented 11 years ago

Nice. SDL_Image is an external library to the usual SDL stuff, isn't it?

dpc commented 11 years ago

Yes. That's bothers me a bit because SDL_image is distributed separately on Linux. However it seems that it's the sanest choice to put all the SDL bindings into one rust-sdl library. In practice users do install all SDL librararies together.

I'm prototyping a little game in Rust to learn the language, so I will probably introduce more stuff, as my program develops.

AngryLawyer commented 11 years ago

Yeah, makes me a bit uncomfortable, too, as I was thinking that sublibraries would have their own repos, but still, what does everyone else think?

pcwalton commented 11 years ago

We could put it behind a cfg flag, so you can choose to compile with it in or out.

AngryLawyer commented 11 years ago

Sounds like a plan, I'll have a read up on what this would entail and get this merged in the week.

kud1ing commented 11 years ago

Would that work using cargo / rustpkg?

AngryLawyer commented 11 years ago

Not entirely sure how cargo/rustpkg work, so I guess we'll work that one out as we come to it. Merging this in, and then adding in the stuff to make it optional.

AngryLawyer commented 11 years ago

Thanks for your effort in this @dpc :)

dpc commented 11 years ago

@AngryLawyer : No problem. Please help me get out of https://github.com/mozilla/rust/issues/4868 as I'm stuck on it ATM and I'm sure more pull requests will follow. :)

AngryLawyer commented 11 years ago

Sure, I'll take a peek if I end up with a free lunchbreak this week.