search

brson / wasm-opt-rs

Rust bindings for Binaryen's wasm-opt
Apache License 2.0
61 stars 10 forks source link

Adjust upstream binaryen methods for const-correctness #122

Open brson opened 1 year ago

brson commented 1 year ago

Related to https://github.com/brson/wasm-opt-rs/issues/104. I still am unconvinced to implement that because it makes the code a bit uglier, and the patterns we are using now work for us.

We could also go upstream and make binaryen methods const-correct, which would let us use the most correct patterns in the bindings.

brson commented 1 year ago

Probably the thing to do is spend a small amount of time seeing how many changes are necessary to convert our bindings to be const-correct, and if that seems reasonable, file an issue upstream about it.