brson / wasm-opt-rs

Rust bindings for Binaryen's wasm-opt
Apache License 2.0
61 stars 10 forks source link

CLI version prints incorrectly #131

Closed brson closed 1 year ago

brson commented 1 year ago

When installed from cargo I see this:

$ wasm-opt --version
wasm-opt version 111 ()

Binaryen looks like

$ ~/binaryen-version_108/bin/wasm-opt  --version
wasm-opt version 108 (version_108)

Probably this is because we are using the same logic to pull out the git tag and I hadn't tagged the release. I am also using a different tagging scheme.

I am not sure the solution to this off hand, whether we should reproduce exactly the string that Binaryen uses or not.

Aimeedeer commented 1 year ago

fixed https://github.com/brson/wasm-opt-rs/pull/133