search

brson / wasm-opt-rs

Rust bindings for Binaryen's wasm-opt
Apache License 2.0
61 stars 10 forks source link

strum 0.25 #162

Open kayabaNerve opened 9 months ago

kayabaNerve commented 9 months ago

This does duplicate the syn dependency, unfortunately (v1 and v2). While there may accordingly be a desired to not merge this, as syn is presumably a heavier depend than strum, the only way the ecosystem will move forward is if eventually people move to syn v2.

brson commented 9 months ago

It looks like this fails the build on our minimum Rust version 1.48:

https://github.com/brson/wasm-opt-rs/actions/runs/7015422941/job/19305682921?pr=162

Seems that syn 2.0 doesn't support such an old compiler.

kayabaNerve commented 9 months ago

Thanks for the context. That's unfortunate.

While I'm fine closing this, mind if I ask why a version of 1.48 was chosen and considerations you'd make when discussing increasing it?