search

brtnshrdr / angular2-hotkeys

Keyboard shortcuts for Angular 2 apps
MIT License
203 stars 95 forks source link

Ivy support / compatibility #112

Closed wittlock closed 4 years ago

wittlock commented 5 years ago

Make the module compatible with Ivy.

See #110 for some details.

kukjevov commented 5 years ago

Take a look at changes from my 2 commits in https://github.com/kukjevov/angular2-hotkeys

i did these changes to make it working. I have tested it partially and it looks like it is working, i will test it more later. I tried to do minimal changes to your project.

kukjevov commented 5 years ago

Ok tested and created pull request https://github.com/brtnshrdr/angular2-hotkeys/pull/113

jpike88 commented 5 years ago

Ah I didn't see this one... though is this really blocking #110 ?

kukjevov commented 5 years ago

I have tested angular 9 prerelease version and they have changed something with ngcc and now it is working with ivy even with current version 2.1.4, which is great, no need to change anything :)

chris13524 commented 5 years ago

What's the status on this? I'm running Angular v8.2.9, but am unable to get this repo working with it.

chris13524 commented 5 years ago

Actually, nevermind me. I was able to get it working with v8.2.9 with Ivy enabled by using this in my package.json:

"angular2-hotkeys": "brtnshrdr/angular2-hotkeys#7a3baca0ddfa4b24ae63dcf09adb559ae232347e",
wittlock commented 4 years ago

Version 2.2.0 was just pushed to npm that is Angular 9 and Ivy compatible. Sorry about the delay. Enjoy!