reduckted commented 4 years ago

Adding support for Angular 10 would be greatly appreciated. ❤️

anders8 commented 4 years ago

This module is working for me in Angular 10, so technically it's "supported", but the new build does give this warning: "angular2-hotkeys.js depends on 'mousetrap'. CommonJS or AMD dependencies can cause optimization bailouts."

So the module needs to be upgraded to a ECMAScript compatible setup so that it can be imported and not have Angular 10 complain. I don't think that requires any code changes. Tack @wittlock !

pcnate commented 4 years ago

must add import { MousetrapInstance } from 'mousetrap'; to hotkeys.service.d.ts

shah20 commented 4 years ago

135

n0mer commented 3 years ago

Package "angular2-hotkeys" has an incompatible peer dependency to "@angular/core" (requires "^5.2.0 || ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0" (extended), would install "11.0.5").

ng update from angular 10 to 11 is not possible, due to pinned @angular/core dependency.

lebe-dev commented 3 years ago

Temporary workaround:

Use --force option during upgrade
Add mousetrap import

d-m-s commented 3 years ago

Adding support for Angular 11 (+12) would be greatly appreciated! ideally without workarounds ;-)

manuelkroiss commented 3 years ago

+1

Coffee-Tea commented 3 years ago

this repo hasn't been updated during last 15 month. new fork probably is needed. I'm even not sure that guy (repo owner) is alive

brtnshrdr commented 3 years ago

Would someone like to take over merge control of this repo?

Coffee-Tea commented 3 years ago

Glad to see you alive!! 🙃

I think @filipelautert is a good candidate as he made needed updates in his fork and even updated README 👍 If he doesn't reply I can take over that and continue supporting that.

filipelautert commented 3 years ago

Hey @brtnshrdr if you could delegate it to me and @Coffee-Tea would be great! Thanks filipe

anders8 commented 3 years ago

Super stuff guys! Just looking on npm, it seems like this package was at 30,000 weekly downloads back in 2020, when it was probably still "current", and it's down at about 11,000 now. I'd expect that number to climb again as it's brought up to current specs. So, first, thanks from ME, as just one user, and I'm sending thanks by proxy from the other tens of thousands of people too. :)

Just was working with this yesterday to add some ctrl-alt-enter support for form submission, getting down to zero mouse for a speed-critical app. 👍

brtnshrdr commented 3 years ago

@filipelautert @Coffee-Tea Could you give me your npm usernames as well? That way you can publish the package yourself under the same name it currently sits at!

brtnshrdr commented 3 years ago

But you both have been granted access! Thanks for taking care of this repo. I stopped Angular development about 5 years ago and just don't keep up with it

Coffee-Tea commented 3 years ago

Hey, @brtnshrdr thanks for replying yesterday and access to this. npm nickname is coffeetea

Coffee-Tea commented 3 years ago

@filipelautert any chances to get your changes in PR into this repo? At least to get fixed mousetrap blocker and Angular 11 compatibility. If no I will try to find some time next weekend to do that

brtnshrdr commented 3 years ago

@Coffee-Tea I've added you as a Maintainer on the npm project. You should now be able to publish updates

filipelautert commented 3 years ago

Hi @nickrichardson-presto - my npm username is @conflito @Coffee-Tea - sure, I'll work to merge my fork to master by this weekend so we can release 2.2.1 and unblock Angular 11 !

brtnshrdr commented 3 years ago

@filipelautert Access granted on NPM as well!

filipelautert commented 3 years ago

Thanks! @Coffee-Tea I just created the merge request, someone needs to review it before It can be merged -> https://github.com/brtnshrdr/angular2-hotkeys/pull/146 . Can you help reviewing it?

Coffee-Tea commented 3 years ago

Should be fixed right now in https://www.npmjs.com/package/angular2-hotkeys v2.3.1

brtnshrdr / angular2-hotkeys

Add support for Angular 10 #132

135