Adopt to new mousetrap types

[BenSL]

With the new @types/1.6.4 angular2-hotkeys is broken. This should fix it.

[nicolasdehouck]

thanks

[feitzi]

Please approve this PR!

[RelentlessResults]

+1

[nodulusteam]

yes please. I've resolved this issue temporarily by using yarn resolutions.

    "resolutions": {   
        "@types/mousetrap": "1.6.3"
    },

[roland-vachter]

+1

[orhanmustafa]

same

[exbachi]

You saved angular from elimination

[falexandre]

+1

[euivanw]

+1

[XeL077]

HI! YEEESSSSS, give my this fix!

[ramonfelizetti]

+1

[thiagomaquito]

+1

[joaomaas]

+1

[fe-telles]

+1

[rafaelmatiello]

+1

[filipermiguel]

+1

[vvnc]

Is there a way to fix this locally via npm the way the CI could build it?

[euivanw]

@vvnc I've used the tip from @nodulusteam and it worked for me, at least, as a workaround!

https://github.com/brtnshrdr/angular2-hotkeys/pull/135#issuecomment-698639561

[vvnc]

@vvnc I've used the tip from @nodulusteam and it worked for me, at least, as a workaround!

#135 (comment)

Does this require npm-force-resolutions package?

[BenSL]

@vvnc use package-lock or shrinkwrap with npm ci command.

[JonathanOldenburg]

+1

[roland-vachter]

The question is: when will this be merged? So many people needs this ...

[kunaljain90]

No need to add resolution incase of npm. You can add "@types/mousetrap": "1.6.3" to your dependencies explicitly till this PR is merged.

dependencies: { "@types/mousetrap": "1.6.3" }

[Daniel-Anjos]

+1

[shah20]

+1

[yevgeniy-belov]

No need to add resolution incase of npm. You can add "@types/mousetrap": "1.6.3" to your devDependencies explicitly till this PR is merged.

devDependencies: { "@types/mousetrap": "1.6.3" }

Didn't work for me. Angular 10.0.12

[roland-vachter]

No need to add resolution incase of npm. You can add "@types/mousetrap": "1.6.3" to your devDependencies explicitly till this PR is merged. devDependencies: { "@types/mousetrap": "1.6.3" }

Didn't work for me. Angular 10.0.12

you should add mousetrap@1.6.3 to dependencies as well

[JamesWPritchett]

No need to add resolution incase of npm. You can add "@types/mousetrap": "1.6.3" to your devDependencies explicitly till this PR is merged. devDependencies: { "@types/mousetrap": "1.6.3" }

Didn't work for me. Angular 10.0.12

you should add mousetrap@1.6.3 to dependencies as well

That works great right up until your build system runs "npm install" and installs 1.6.4, ignoring your hardcoded dependency version.

[BenSL]

@wittlock @brtnshrdr @isaacplmann @AnBauer @nlmueng @DennisRoam pls merge this request and make a new release. i would do by myself if i had the rights to publish. :)

[blake-haas]

@wittlock @brtnshrdr @isaacplmann @AnBauer @nlmueng @DennisRoam Please merge this for new release.

[akashlinasayed]

I am trying to implement "ctrl" and "+" using Hotkeys and it doesn't work (ctrl+- works fine). Is this anything to do with mousetrap?

export class MyClass { zoomInHotkey: Hotkey; constructor(private readonly hotkeys: HotkeysService) { this.zoomInHotkey = new Hotkey(['ctrl++'], () => this.invokeMyZoomInFunction(), ['input', 'textarea', 'select']); //doesn't invoke my zoom in function } }

[gustavoraphael]

+1

[SvyatoslavZhuravlev]

+1

[yevgeniy-belov]

@wittlock @brtnshrdr @isaacplmann @AnBauer @nlmueng @DennisRoam, Is there any reason why this PR can't be merged? What is missing?

[mikejoseph23]

I am also waiting for a merge to happen. In the meantime, I've tried the work-arounds suggested in this thread and none of them have worked. I've tried:

• Adding "@types/mousetrap": "1.6.3" to devDependencies
• Adding "@types/mousetrap": "1.6.3" to dependencies
• Adding "@types/mousetrap": "1.6.3" to BOTH devDependencies and dependencies
• Creating a resolutions section in my package.json and adding "@types/mousetrap": "1.6.3" to it.
• Adding "@types/mousetrap": "1.6.3" to ALL three dependencies, devDependencies and resolutions.

None of these attempts yielded a successful build and gave me the same error: ERROR in node_modules/angular2-hotkeys/lib/hotkeys.service.d.ts:10:16 - error TS2304: Cannot find name 'MousetrapInstance'.

The only way that this gets fixed is if I do exactly what this pull request would do, which is go into my /node_modules/angular2-hotkeys/lib/hotkeys.service.d.ts and add the following line to the imports: import { MousetrapInstance } from 'mousetrap';

Once I do that, a build succeeds. This isn't ideal because since obviously node_modules aren't in source control, I have to open up the file on my build server and make the same change for it to work. Since my build doesn't clean the build directory each time, this works for now, but the fix needs to be repeated any time I do a clean build.

Hope my post saves someone else some time.

[mikejoseph23]

I was wrong about my CI build being OK. The last build I ran got rid of my change so every time I want to build, it can potentially break. I added this hack to my build process: After my npm install runs (or yarn in my case), I run the following powershell script prior to running my Angular build:

(Get-Content .\node_modules\angular2-hotkeys\lib\hotkeys.service.d.ts).replace("import 'mousetrap';", "import {MousetrapInstance} from 'mousetrap';") | Set-Content .\node_modules\angular2-hotkeys\lib\hotkeys.service.d.ts

It's ugly but it works for now.

[lazar-vuckovic]

I was wrong about my CI build being OK. The last build I ran got rid of my change so every time I want to build, it can potentially break. I added this hack to my build process: After my npm install runs (or yarn in my case), I run the following powershell script prior to running my Angular build:

(Get-Content .\node_modules\angular2-hotkeys\lib\hotkeys.service.d.ts).replace("import 'mousetrap';", "import {MousetrapInstance} from 'mousetrap';") | Set-Content .\node_modules\angular2-hotkeys\lib\hotkeys.service.d.ts

It's ugly but it works for now.

Until the PR gets merged, you can use npm-force-resolutions and pin the version down to "resolutions": { "@types/mousetrap": "1.6.3" },

[malteboettcher]

When will this be merged?

[mikejoseph23]

@gszymonik Thanks for approving this! Who is responsible for merging this?

[KGDI01]

The workaround using @mikejoseph23 suggestion above worked for me.

Edit "node_modules/angular2-hotkeys/lib/hotkeys.service.d.ts"

Comment out / remove: import 'mousetrap';

Add: import { MousetrapInstance } from 'mousetrap';

[d3-vitalii-baziuk]

@BenSL pls close your PR. It's resolved in https://www.npmjs.com/package/angular2-hotkeys v2.3.1

[Coffee-Tea]

It's resolved in https://www.npmjs.com/package/angular2-hotkeys v2.3.1

[swapnil28verma]

I'm facing this issue again in v2.3.2. Following imports are being used - "angular2-hotkeys": "^2.3.2", "@types/mousetrap": "1.6.3",

EDIT: Never mind, figured it out. Turns out the explicit import I had of @types/mousetrap was causing the issues, because it downloaded an older version of the dependency which is no longer compatible with angular2-hotkeys. Once I removed that dependency from package.json (also deleted package-lock.json, just for good measure) and re-ran npm install, it downloaded the correct versions, and builds fine now

[dineshkumarv-ict]

Please approve this PR!

[Coffee-Tea]

@dineshkumarv-ict This adjustment is done a long time ago, please use the latest version.