search

brtnshrdr / angular2-hotkeys

Keyboard shortcuts for Angular 2 apps
MIT License
203 stars 95 forks source link

Cypress clicks on hidden hotkeys-cheatsheet component #160

Closed sebastianzillessen closed 1 year ago

sebastianzillessen commented 2 years ago

In our application we use the hotkeys-cheatsheet component to display the cheatsheet.

The current combination of

visibility: hidden; display: none; display: table !important;

Keeps the element always in the DOM and causes Cypress sometimes to 'click' on not visible, but existing elements from the Hotkeys Overlay.

Could we reformat this and only use display: none and display: table for the classes fade and fade in?

Coffee-Tea commented 1 year ago

fade and fade in won't work if we apply it will be based on display rule. please update your e2e tests logic/selectors. Thanks!