brtnshrdr / angular2-hotkeys

Keyboard shortcuts for Angular 2 apps
MIT License
203 stars 95 forks source link

Is it compatible with Angular v16+ #171

Closed Yuri-Lima closed 1 year ago

Yuri-Lima commented 1 year ago

ERROR DESCRIPTION:

ERROR:

Screenshot 2023-07-26 at 18 35 34

PACKAGE.json

Screenshot 2023-07-26 at 18 36 35

Screenshot 2023-07-26 at 18 37 32

Screenshot 2023-07-26 at 18 37 41

JanneHarju commented 1 year ago

I need 16.0.0 version as well.

error NG6002: 'HotkeyModule' does not appear to be an NgModule class.

11 imports: [HotkeyModule.forRoot()],


  node_modules/angular2-hotkeys/lib/hotkey.module.d.ts:3:22
    3 export declare class HotkeyModule {
This likely means that the library (angular2-hotkeys) which declares HotkeyModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.
JanneHarju commented 1 year ago

My problem was that there was extra node_modules folder in my library folder which was used. So there was old version of this package. I tired 15 version with my angular 16 application and it worked just fine. But still I made this PR which update dependecies to angular 16. https://github.com/brtnshrdr/angular2-hotkeys/pull/172

Coffee-Tea commented 1 year ago

@Yuri-Lima v16 is published to npm, you can test it out on your project(s). Thanks!

Yuri-Lima commented 11 months ago

@Coffee-Tea I am facing that Build error, do you have any idea?

Screenshot 2023-12-18 at 15 45 05

Update, if i use your lib as a internal module, it means without instaling the package itself, it works fine. Maybe it something EMS FEMS, commonModule..... Not sure, i didnt dig into that.

Coffee-Tea commented 10 months ago

Hey @Yuri-Lima, sorry it's not mine lib :) I just was trying to keep it alive like a few other guys.

TBH I'm not sure what could be an issue and, unfortunately, have no time to research, but u could invest your time and propose a PR and maybe it will give you a better chance to get that fixed faster.

Do I understand correctly it's related to Angular v17 but not v16?

Yuri-Lima commented 10 months ago

Hi, @Coffee-Tea it still related to the v16. The interesting point here is if i copy the entire module to my module folder it works without any problem. However if i just install and follow the the steps to add the module as required by the lib. it doesn't work.

I am using for now like that, if i find some time also, i will investigate a bit more.

Screenshot 2024-01-11 at 15 24 44