search

brtnshrdr / angular2-hotkeys

Keyboard shortcuts for Angular 2 apps
MIT License
203 stars 95 forks source link

Angular build warning: Mousetrap commonjs dependency #175

Open joeywisse opened 1 year ago

joeywisse commented 1 year ago

While building my app I get the following warning.

Warning: /home/joey/repositories/detact/webapp/node_modules/angular2-hotkeys/fesm2022/angular2-hotkeys.mjs depends on 'mousetrap'. CommonJS or AMD dependencies can cause optimization bailouts. For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies Mousetrap is used by angular2-hotkeys. I can suppress the warning by adding mousetrap to the angular.json 'allowedCommonJsDependencies' list.

CommonJS increases the bundle size https://angular.io/guide/build#configuring-commonjs-dependencies.

I would like to get rid of using mousetrap as a commonjs dependency.

Coffee-Tea commented 1 year ago

Hey, thanks for the great idea! We're currently trying to make critical support only like real blockers or Angular version upgrades. I have no idea regarding the business logic of this package and mousetrap usage at all. The original creator doesn't contribute here anymore. Feel free to create PR and we could review and try it out. If all will be fine it will be published. Thanks!