search

brtnshrdr / angular2-image-zoom

An Angular2 Image Zoom Directive
MIT License
22 stars 15 forks source link

doesn't work with angular2 rc4 #1

Closed Avareto closed 8 years ago

Avareto commented 8 years ago

Hi Nick!

great work! That was exactly what I was looking for but It looks like there is an issue with angular2 rc4? It would be great if you could provide a simple sample or demo with your code, just to validate the directive use and comatibility with other framework versions. Thanks! Andreas

xavierclotet commented 8 years ago

Yes, i'd like to use this image zoom but maybe is not finished yet. When this will be available?

  1. Allow window to be placed anywhere
  2. Show viewing lens over image to show zoom area

Thx!

brtnshrdr commented 8 years ago

Those features are actually already implemented, I just haven't updated the TODO section of the README

brtnshrdr commented 8 years ago

@Avareto Sorry, I didn't see your comment before. What issues exactly are you having?

Avareto commented 8 years ago

angular2.rc4 requires the forms package 2.0! Your package still references the v1.0. The issue pops up when you try to install your package with an angular2.rc4 app. Try this with angular cli installed (npm install -g angular-cli): ng new image-zoom cd image-zoom npm install angular2-image-zoom --save !! this already stops with an error.

brtnshrdr commented 8 years ago

I've updated the @angular/core package to rc4 and remove the other @angular packages that weren't needed. Can you let me know if that fixes your problems? (It's now version 0.5.0)

Avareto commented 8 years ago

unfortunately not..still getting the same error...?

brtnshrdr commented 8 years ago

Are you able to upload a screenshot of the error you're getting? I seem to be able to use it alongside rc4 fine. I'm also not using any of the @angular/forms stuff (old or new)

Avareto commented 8 years ago

error

Avareto commented 8 years ago

npm-debug.log.txt

brtnshrdr commented 8 years ago

Sorry. I missed updating the "devDependencies" section in the package.json. It's fixed and published as "0.5.1". You should be good to go now!

Avareto commented 8 years ago

nope...still the same issue. ng new image-zoom cd image-zoom npm install angular2-image-zoom --save !!!! error

brtnshrdr commented 8 years ago

What version of angular-cli are you using?

Avareto commented 8 years ago

angular-cli: 1.0.0-beta.9 node: 4.4.7 os: win32 x64

brtnshrdr commented 8 years ago

Can you post your package.json file as well?

Avareto commented 8 years ago

{ "name": "image-zoom", "version": "0.0.0", "license": "MIT", "angular-cli": {}, "scripts": { "start": "ng serve", "postinstall": "typings install", "lint": "tslint \"src/*/.ts\"", "test": "ng test", "pree2e": "webdriver-manager update", "e2e": "protractor" }, "private": true, "dependencies": { "@angular/common": "2.0.0-rc.3", "@angular/compiler": "2.0.0-rc.3", "@angular/core": "2.0.0-rc.3", "@angular/forms": "0.2.0", "@angular/http": "2.0.0-rc.3", "@angular/platform-browser": "2.0.0-rc.3", "@angular/platform-browser-dynamic": "2.0.0-rc.3", "@angular/router": "3.0.0-alpha.8", "es6-shim": "0.35.1", "reflect-metadata": "0.1.3", "rxjs": "5.0.0-beta.6", "systemjs": "0.19.26", "zone.js": "0.6.12" }, "devDependencies": { "angular-cli": "1.0.0-beta.9", "codelyzer": "0.0.20", "ember-cli-inject-live-reload": "1.4.0", "jasmine-core": "2.4.1", "jasmine-spec-reporter": "2.5.0", "karma": "0.13.22", "karma-chrome-launcher": "0.2.3", "karma-jasmine": "0.3.8", "protractor": "3.3.0", "ts-node": "0.5.5", "tslint": "3.11.0", "typescript": "1.8.10", "typings": "0.8.1" } }

Avareto commented 8 years ago

Looks like that cli is still on rc.3

Avareto commented 8 years ago

That was my problem, sorry.

  1. I simply replaced rc.3 with rc.4
  2. npm install
  3. npm install angular2-image-zoom --save

and it installs without any errors.

THANKS for you great support !!!

brtnshrdr commented 8 years ago

Well glad it works now!

brtnshrdr commented 8 years ago

I've upgraded the package to be RC.6 compatible btw!