search

brtnshrdr / angular2-image-zoom

An Angular2 Image Zoom Directive
MIT License
22 stars 16 forks source link

Scroll in lens handled on IE11 #18

Closed badjilounes closed 6 years ago

badjilounes commented 6 years ago

First of all, thank you for your time, your package just ran as I expected.

I just used event properties to know if the mouse is wheeling up or down on IE11. I tried on IE11/Chrome/Safari/Firefox with an Angular 4.4.6 project and it works as expected. I did not have time to do nor unit tests nor e2e tests.

Last but not least, your package works on Angular 4.x.x projects, if you want to specify it in README.md.

To be continued !

Lounes Badji, Regards.

badjilounes commented 6 years ago

Hey @brtnshrdr !

brtnshrdr commented 6 years ago

Sorry for the delay. But I do NOT want all the generated .d.ts, .js, .map, etc.. stored in git. If you change your request to only include src/image-zoom.directive.ts, I'll merge it in!

brtnshrdr commented 6 years ago

@badjilounes

badjilounes commented 6 years ago

@brtnshrdr DONE!