search

bruceravel / demeter

Process and analyze X-ray Absorption Spectroscopy data using Feff and either Larch or Ifeffit.
http://bruceravel.github.io/demeter
Other
67 stars 32 forks source link

A few more tweaks to Larch.pm #44

Closed newville closed 7 years ago

newville commented 7 years ago

still may need work, but this fixes a few things.

bruceravel commented 7 years ago

@newville : I rejected this PR, but used two of the three fixes verbatim. Thanks.

I changed the last few lines (also reducing chatter in the same way that you proposed ... so I guess I used all three...). It is important that Larch.pm report on whether the larch server was successfully started. This is done with the value of the $larch_is_go scalar in the last executable line of the main part of the module. When that is 1, Demeter goes ahead and used Larch. When it is 0, Demeter falls back to using Ifeffit.

In this way, someone can install Demeter without installing Larch. Undesirable user behavior in the long run, but sensible behavior for Demeter.

Oh! I also fixed the chi(k) problem. Thanks for catching that!