search

bruceravel / demeter

Process and analyze X-ray Absorption Spectroscopy data using Feff and either Larch or Ifeffit.
http://bruceravel.github.io/demeter
Other
67 stars 32 forks source link

lcf_fit bug #58

Open tschoonj opened 6 years ago

tschoonj commented 6 years ago

Hi @bruceravel @newville

Some of our B18 staff have run into a bug when trying to perform linear combination fitting in Athena (Demeter 0.9.26) with Larch 0.9.40 backend.

Basically the fit fails with an error dialog with contents:

06:12:34 PM: Argument "RPC::XML::Client::send_request: parse-level error: Bad f..." isn't numeric in addition (+) at /usr/lib64/perl5/vendor_perl/Demeter/LCF.pm line 458, <F> line 27.
06:12:35 PM: Argument "RPC::XML::Client::send_request: parse-level error: Bad f..." isn't numeric in sprintf at /usr/lib64/perl5/vendor_perl/Demeter/UI/Athena/LCF.pm line 610, <F> line 27.

At the same time the terminal shows the error message:

NameError
   <_ast.Module object at 0x7feff89f6890>
       ^^^
name 'demlcf' is not defined

I did some digging in the code to try and understand where this is coming from and it would appear to be coming out of the Larch lcf_fit template:

https://github.com/bruceravel/demeter/blob/8245df1fe26de93d0c9db321f10ddb6461c362dd/lib/Demeter/templates/analysis/larch/lcf_fit.tmpl#L13-L15

I failed to come up with a fix for it however 😢

Let me know if you need any further information!

bruceravel commented 6 years ago

It's 100% an @bruceravel problem. I am pretty swamped at the beamline this week, but I'll try to get to it ASAP.

newville commented 6 years ago

@tschoonj I would be interested to know if you or any of the B18 staff have tried the Linear Combo capabilities in Larch's XAS Viewer (included in 0.9.40) and whether you all might have any comments on it.

tschoonj commented 6 years ago

I'll ask around.

tschoonj commented 5 years ago

Hi Bruce,

Have you had some time to look into this issue?

Thanks,

Tom