brucethemoose / Minecraft-Performance-Flags-Benchmarks

Sane, Benchmarked Java Flags and Tweaks for Minecraft
MIT License
1.34k stars 29 forks source link

-XX:+PerfDisableSharedMem Argument is set multiple times #22

Open PureFallen opened 1 year ago

PureFallen commented 1 year ago

Upon digging deeper into the list of JVMs used in each scenario, i realized that -XX:+PerfDisableSharedMem is set multiple times across the argument Lists, but also in ways that not seem to make sense for me.

As of now, the argument gets set at:

The confusion comes mostly of the Client G1GC entry here. Aside from the missing entry for GraalVM 8, the argument always ends up set regardless which Base is used and as such across all possible GC selections, so i don't see why it would need to be set an additional time for G1GC. As such i am wondering whenever the argument can be added to the GraalVM 8 List and removed from the G1GC list, or if there is a benchmark i did miss which shows that other GCs suffer from it. Under that circumstances, it should probably be removed from all the Base Flags.