search

brucetoo / PickView

Date and Province WheelView like IOS
1.1k stars 265 forks source link

bug #31

Closed k525245669 closed 8 years ago

k525245669 commented 8 years ago

when i set the app:drawItemCount to more then 7, then the centerText will in incorrect position.I'm trying to fix this bug, if i fixed ,can you merge my code?

brucetoo commented 8 years ago

PR is so welcome..and i will check it.

brucetoo commented 8 years ago

drawItemCount must be odd number and please check out if the initPosition is what you set. " the centerText will in incorrect position " it seems cause by your initPosition params

k525245669 commented 8 years ago

thanks, i found it cause by drawItemCount, because i set it to 10. How about to check the mDrawItemCount in the initView(Context context, AttributeSet attrs) like: if(mDrawItemsCount%2==0) mDrawItemsCount++; thanks for this bug, it drive me to read your code carefully, the code in onDraw is so cool, Thanks

brucetoo commented 8 years ago

before you use this lib.it's better to read README.md first.