PluginManager 1.4.11 causes NppPortable to delete config files

[einst3]

Description of the Issue

updating Notepad++Portable 7.5.6 PluginManager (UNI) from version 1.4.10 to 1.4.11 it causes Notepad++Portable to remove all my \PortableApps\Notepad++Portable\Data\Config\plugins\config*.ini settings files and folders. especially DSpellCheck settings and the Hunspell and Tidy folders. issue does not occur prior to and ver 1.4.10.

Steps to Reproduce the Issue

1. install PortableApps installer, install Notepad++Portable 7.5.6
2. download PluginManager 1.4.10 (UNI) zip and install Plugins\PluginManger.dll and updater\gpup.exe
3. open/close Notepad++Portable a couple of times. everything is ok.
4. update the PluginManager to 1.4.11 from online or manually. close/open program a few times, and close program.
5. look in \PortableApps\Notepad++Portable\Data\Config\plugins\config and the DSpellCheck.ini 1.3.5 and Hunspell & Tidy folders and some config files disappear.

Expected Behavior

update occur and no loss of data\config\plugins\config files

Actual Behavior

data\config\plugins\config files get removed and only PluginManger files and some ini files remain

Debug Information

Notepad++ v7.5.6 (32-bit) Build time : Mar 19 2018 - 00:26:59 Path : C:\PortableApps\Notepad++Portable\App\Notepad++\notepad++.exe Admin mode : OFF Local Conf mode : ON OS : Windows 7 (64-bit) Plugins : latest versions except where noted... DSpellCheck.dll(1.3.5) mimeTools.dll NppConverter.dll NppExport.dll PluginManager.dll(1.4.10)

[chcg]

@einst3 It is very unlikely that 1.4.11 is causing this. There was just one small drawing fix contained in https://github.com/bruderstein/nppPluginManager/releases/tag/v1.4.11. If this issue is caused by PM it should also appear in 1.4.10 and before.

You used the N++ version from https://portableapps.com/ ?

ad 4. What means open\close program? Just N++ ? Or also downloading the PM list what happens on first opening of the PM menu?

Maybe the update of the PM itself is already causing such a problem if not done manually. Or the update of a plugin from within the plugin manager. Maybe also the storage of the plugin list data.

[einst3]

i have noticed this before and it only started happening after 1.4.5, since i manually updated the portableapps version (yes portableapps.com) and my installed desktop version manually since then i didnt notice it until pm 1.4.11.

i grabbed npp 7.5.6 (latest) from portableapps installer and installed it. i then added pm 1.3.5 uni and updated it online with 1.4.5 uni. to use pm and download the plugin list i have to enable http only for downloads.

after this it works fine and no matter what plugins i add and no matter how many time i open/close npp portableapps it works fine. if i update PM manually to 1.4.10 npp portableapps still works fine, no issues, as soon as i update to 1.4.11 either manually or through pm update it kills my config files.

i think i have given you enough info to debug from here. you may have to work with npp portableapps if there is anything squirrel with the portable version.

i will test with the npp desktop install and npp zip versions and let you know. i dont know how to test the other download versions of pm since it wants to update to 1.4.11 online. is there a way i can manually set what version to download and a url for testing? thanks =)

[einst3]

pm seems to work fine for npp desktop install and zip versions. only portableapps has issues. i wonder if its because it moves config files from C:\PortableApps\Notepad++Portable\Data\Config\plugins to C:\PortableApps\Notepad++Portable\App\Notepad++\plugins\config but the plugins stay fixed in the folder C:\PortableApps\Notepad++Portable\App\Notepad++\plugins and moves npp files from C:\PortableApps\Notepad++Portable\Data\Config to C:\PortableApps\Notepad++Portable\App\Notepad++ and back again.

[einst3]

investigating the pm in npp the zip and install versions are ok but the portableapps.com ver does not update the gpup.exe but updates the dll. fyi

[einst3]

i saw this post on npp community is this true? if so where in the release notes is this? https://notepad-plus-plus.org/community/topic/15981/notepad-7-5-7-release/7

chcg posted @donho There is a modification in plugin distribution with this version not mentioned in the release notes at all. This breaks compatibility with PluginManager. DSpellcheck is still 1.3.5 with https://github.com/Predelnik/DSpellCheck/releases/tag/v1.4.5 to be the current one.

donho posted @chcg said: There is a modification in plugin distribution with this version not mentioned in the release notes at all. This breaks compatibility with PluginManager. Which one? Could you provide me more detail?

chcg posted The plugin dlls are no longer directly located under the plugin folder, but have a subfolder named like the plugin, e.g. …\plugins\DSpellCheck.dll is now …\plugins\DSpellCheck\DSpellCheck.dll

donho posted @chcg said: The plugin dlls are no longer directly located under the plugin folder, but have a subfolder named like the plugin, e.g. …\plugins\DSpellCheck.dll is now …\plugins\DSpellCheck\DSpellCheck.dll The loading behaviour is retro-compatible, but indeed the new plugin file system is applied to the new release.

[chcg]

See #127