brug-be / rubybelgium

Ruby Belgium website
https://rubybelgium.be
MIT License
5 stars 11 forks source link

New banner #6

Closed toch closed 9 years ago

toch commented 9 years ago

Fixes #5

toch commented 9 years ago

@otagi @brug-be/owners what do you think? screenshot from 2015-10-19 23 48 16

joren commented 9 years ago

Nice. I really like it!

Joren

Op 19 okt. 2015 om 23:48 heeft Christophe Philemotte notifications@github.com het volgende geschreven:

@otagi @brug-be/owners what do you think?

— Reply to this email directly or view it on GitHub.

ys commented 9 years ago

Good choice

On Tue, Oct 20, 2015 at 7:39 AM Joren De Groof notifications@github.com wrote:

Nice. I really like it!

Joren

Op 19 okt. 2015 om 23:48 heeft Christophe Philemotte < notifications@github.com> het volgende geschreven:

@otagi @brug-be/owners what do you think?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/brug-be/rubybelgium/pull/6#issuecomment-149438217.

otagi commented 9 years ago

Great picture! There is still some white-on-white text, depending on the window width (with the city hall tower), but it's fairly readable nonetheless.

The credits caption is a nice touch.

Maybe add some bottom margin to the h2 where the h3 were removed? The former currently has 15px, and the latter 75px, so less whitespace. What do you think?

toch commented 9 years ago

Just pushed a few minor changes:

ok for you?

otagi commented 9 years ago

Neat!

I applied your margin to the events title as well.

Time for a merge!

otagi commented 9 years ago

The new master is deployed.

toch commented 9 years ago

:shipit: :+1: thX!

joren commented 9 years ago

:+1: I've contacted the Atomium people we changed the picture.

toch commented 9 years ago

@joren thanks!

otagi commented 9 years ago

:+1: