brug-be / rubybelgium

Ruby Belgium website
https://rubybelgium.be
MIT License
5 stars 11 forks source link

codeofconduct #70

Closed prayagb closed 8 years ago

prayagb commented 8 years ago

Add a code of conduct page fixes #59

Copied text from github and created 2 versions - one with text-column to be in sync with other pages and one without text-column. Let me know which is preferable along with any other suggestions.. code-1 code-2 code-3 code-4 code-5 code-6

borisrorsvort commented 8 years ago

@prayagb I'd keep the first version (with 2 column) but now that I'm thinking about it the second part would fit more in a about page. So you can remove it from here but I'll keep it for inspiration when I'll redo the about page.

prayagb commented 8 years ago

Removed the one-column version and retained the 2-column version

toch commented 8 years ago

Thanks a lot @prayagb there are two comments to address.

Could you also add a link to the GitHub repository of the code of conduct at then end. Something link "would you like to suggest improvements, or corrections to the present code of conduct, please submit them to its repository."

prayagb commented 8 years ago

Changed email to safe@rubybelgium.be and added link to the github repo.

prayagb commented 8 years ago

sure. should I otherwise leave it as it is (only the word 'repository' is a link) or should I make the whole line a link - the reason I am asking is that it is not evident that the word 'repository' is a link....

borisrorsvort commented 8 years ago

Links are red by default so actually remove the .red class. Keep the text in black and the link would be red automatically. Also you should rebase on master

prayagb commented 8 years ago

Ok rebased master and removed underline

prayagb commented 8 years ago

removed left-spaced class but the subheadings have turned black. not easily turning red. should I continue to try and change to red? if you have a quick tip, I would love to hear....

borisrorsvort commented 8 years ago

If you look in other pages, titles who are in a .header are red. Thar's one way ;) Make sure they centered also

prayagb commented 8 years ago

maybe finally got it? Thanks for your patience

borisrorsvort commented 8 years ago

Dont reivent the wheel, try to reuse what on other pages ;) developer_tools_-_httprubybelgium berails-girls_2016-07-10_10-13-26

prayagb commented 8 years ago

does it look ok now? it certainly looks better to me :smile:

borisrorsvort commented 8 years ago

prayagb commented 8 years ago

hahaha, this one took a while - but a couple of lessons learnt....

borisrorsvort commented 8 years ago

@prayagb I had to make some adjustments, have a look https://github.com/brug-be/rubybelgium/commit/c73c3482995cee1fb822ca837f9b6aa520966177

toch commented 8 years ago

Great job :clap: