search

bruhautomation / ESP-MQTT-JSON-Digital-LEDs

(OBSOLETE) ESP8266 MQTT JSON Digital LEDs for Home Assistant
https://youtu.be/9KI36GTgwuQ
Apache License 2.0
512 stars 268 forks source link

adding simple music visualizer #82

Open hamidzr opened 6 years ago

hamidzr commented 6 years ago

Are people insterested in having this music visualizer added as an option to the list of effects as an option? it would require that you also add a 1$ sound detector to your setup.

encor50 commented 6 years ago

But how do you add the code ? I dont think it will work as an effect

hamidzr commented 6 years ago

i've already merged it with my own use it's possible I can clean it and make a pull request if @bruhautomation thinks this repo is a good place for it.

encor50 commented 6 years ago

Can you send me your code ? On pastebin or so ? If you want here is my code https://github.com/bruhautomation/ESP-MQTT-JSON-Digital-LEDs/issues/32#issuecomment-336731495

hamidzr commented 6 years ago

thanks. why didn't you fork and make a PR from it? I will prepare and share it when I get a chance. weekend at the latest.

hamidzr commented 6 years ago

I forked the repo and added in my changes. it's available at my fork. I'll clean up the code and make a pull request once @bruhautomation approves

I'm not home so I can't test if I did this correctly. But I am using this at my apartment so it's doable. Let me know if it works for you

roandegraaf commented 6 years ago

I implemented it into my code, but when I set it to the visualizer effect in HomeAssistant the ledstrip just turns off and when I turn it on again it's solid. I can't find out where it goes wrong.

hamidzr commented 6 years ago

do you have a sound detector attached and working properly?

roandegraaf commented 6 years ago

Yes, I tested it on another Arduino and the sound detector does work.

hamidzr commented 6 years ago

I assume you also defined the port in the code properly. This is the exact code i'm using in my own setup (minus the passwords, IPs, sensor name and mqtt topics) https://pastebin.com/tXGJb28X take a look and see if it helps. If you managed to find out whats missing from my fork let me know so I can update it.

If you still failed to make it work I encourage you to take a look at the original music visualizer's repo and get that to work first then come back to this.

roandegraaf commented 6 years ago

Thank you so much! I'm not home the next two days but when I get home I'll check if I can get it working

hamidzr commented 6 years ago

@gfhoihoi72 could you get it to work?

Fma965 commented 5 years ago

I have implemented a music visualizer in my fork. https://github.com/cyanlabs/ESP-MQTT-JSON-Digital-LEDs