Restructure + Automation

bruhautomation / ESP-MQTT-JSON-Multisensor

(OBSOLETE) ESP MQTT JSON Multisensor for Home Assistant. Supported sensors include the TEMT6000 light, AM312 PIR, DHT22 temperature/humidity sensors. RGB led supports flash, fade, and transition. Over-The-Air (OTA) uploading, too!

https://youtu.be/jpjfVc-9IrQ

Apache License 2.0

340 stars 152 forks source link

Restructure + Automation #23

Closed jlmcgehee21 closed 6 years ago

jlmcgehee21 commented 7 years ago

Why:

The "flatness" of the project structure was getting messy as I was adding more files.
I ordered an initial batch of parts to make four of these sensors and hope to make many more. This led me to automate the procedure.

This change addresses the need by:

Moving files to sensably named directories where applicable.
Creating jinja2 templates from the original .ino file and the example home assistant config.
Creating ./bin/generate which auto-generates an Arduino project and example home assistant config.

bruhautomation commented 7 years ago

Hello! Thanks for this awesome code. Love the things you've implemented here. I want to play with this code before I merge it because it's such a big change.

My only concern is that I'd like to maintain an original .ino file that I talk about in the vid. Some people really will just want to copy/paste from the web into a sketch and be off and going. Other people will love this auto generating method. It's sick.

I'm going to get around to merging this code later this week and probably just maintain an additional .ino for people who want to stick to the original method.

Thanks much for these additions. They're awesome!

jlmcgehee21 commented 6 years ago

@bruhautomation, let me know if there is anything I can do to help.. If things work out with this, it's my goal to make a PYPI package so the automation script will be installable via pip.

DanielXYZ2000 commented 6 years ago

I just hat a look a the changes - really cool! I would suggest to make a fork for this restructuring and add a link in the README.md file, since this targets more experienced users. Not every windows user has python, hence they migh prefer one single .ino-file

jlmcgehee21 commented 6 years ago

@DanielXYZ2000 I agree, I haven't had much time to work on this since I approved it, but that seems to be the best path forward.