search

bruhov / WinThumbsPreloader

WinThumbsPreloader is a simple open source tool for preloading thumbnails in Windows Explorer.
MIT License
563 stars 38 forks source link

Support for multi-threading / multiple cores? #6

Open archfrog opened 4 years ago

archfrog commented 4 years ago

Hi,

I regularly use WinThumbsPreloader and love it. However, it seems that it only uses a single core.

Would it be difficult to extend the app to support any number of cores for concurrent generation of thumbnails? My pictures are on an SSD and I've got a 12-core AMD Ryzen 3900X CPU.

Cheers, Archfrog

dadiborn commented 4 years ago

Hi,

I regularly use WinThumbsPreloader and love it. However, it seems that it only uses a single core.

Would it be difficult to extend the app to support any number of cores for concurrent generation of thumbnails? My pictures are on an SSD and I've got a 12-core AMD Ryzen 3900X CPU with 12 cores.

Cheers, Archfrog

Not Agree that we need any kind of change. Try to select multiple folders and then run it from right click context menu. You will see multiple processing instances (each folder own processing), and take a look in your process manager during this :)

archfrog commented 4 years ago

That should work for me, thanks. Please feel free to close this issue :-)

archfrog commented 4 years ago

Uhm, I just tried on Windows 10 1909 and eleven windows pop up, but nothing happens. If I open Windows Explorer and browse to a folder that I have already generated thumbnails for, only the standard placeholder icon is shown.

Cancelling the eleven running jobs doesn't help - it seems like a deadlock of some sort as the cancel operation never completes.

I had to use Task Manager to manually close each of the eleven running instances of WinThumbsPreloader.

meyergru commented 3 years ago

The approach of selecting multiple directories to speed up things is not feasible when all files reside on a single drive in just one directory. I think it should be easy to parallelize processing in the main loop of ThumnailsPreloader by using await and having multiple threads, probably with a setting of how many threads to use.

mdrejhon commented 2 years ago

Oops, I may have made a duplicate -- https://github.com/bruhov/WinThumbsPreloader/issues/19

There is already a fork of WinThumbPreloader that is apparently multithreaded.