search

bruiken / Notepad--

Notepad--, a lightweight web based editor with numerous optional features.
MIT License
3 stars 0 forks source link

Fix padding / line wrapping for every situation #17

Closed bruiken closed 3 years ago

bruiken commented 3 years ago

For me this works in all possible configurations of highlighting - line numbers and both in firefox and chrome.

jwijenbergh commented 3 years ago

Looks to have solved the scrolling / overflow issue. The padding looks a little awkward right now, but not an issue per se. Since the padding might clash again with the overflow, overflow is in my opinion the better of the two to have solved.

Shouldn't padding be disabled now?

bruiken commented 3 years ago

I think the idea is that it looks a bit awkward since there is no padding anymore.

Justin-Reniers commented 3 years ago

That's exactly what I meant, especially on the right side and in comparison with the line numbers. The line numbers seem to be like 1 or 2 pixels higher, and there's the last character of an overflowing line that seems to be slightly cut off. However, I'd take that over the overflow issues any day.

jwijenbergh commented 3 years ago

I think the idea is that it looks a bit awkward since there is no padding anymore.

Ah okay.

Confirmed works on firefox. This can be merged imo.