search

bruiken / Notepad--

Notepad--, a lightweight web based editor with numerous optional features.
MIT License
3 stars 0 forks source link

Feature: Control click on function to go to definition #19

Closed bruiken closed 3 years ago

bruiken commented 3 years ago

Implementation for: #10

TODO:

jwijenbergh commented 3 years ago

Works very nice :). This will obviously not work on everything, maybe an error or warning when no function is found?

jwijenbergh commented 3 years ago

Good additions of warnNotification(string) and infoNotification(string). Works perfectly, thanks. Will approve once documentation is done.

bruiken commented 3 years ago

image The editor gets misaligned when using a lot of newlines, needs fix.

bruiken commented 3 years ago

The last changes fixes the given bug. The problem was that the function definitions get saved in a list. But that list should be cleared when pressing control again. Otherwise, the old values for the function definitions always get chosen instead of the new ones.

Justin-Reniers commented 3 years ago

From the images: when using the control click feature, the scroll seems to be missing the mark completely, where it should go to the function at the bottom (which gets highlighted), but instead the editor scrolls up a significant portion of the textarea.

Issue seems to be specifically when control clicking on a function that calls itself AND that function is calling itself in its body.