search

bruiken / Notepad--

Notepad--, a lightweight web based editor with numerous optional features.
MIT License
3 stars 0 forks source link

Search buttons #21

Closed huynguy97 closed 3 years ago

huynguy97 commented 3 years ago

Search buttons rewritten into AOP style. Should be split in files properly now.

bruiken commented 3 years ago

Looks good! We only need to rebase with master before merging, but we will do that once everyone agrees on the changes.

bruiken commented 3 years ago

Branch is rebased with master, merging can be done automatically. If you want to test this branch now, delete it locally and pull it again :)

huynguy97 commented 3 years ago

Updated:

  1. SelectedText code now works properly on firefox as well. Had to change the whole code for that. Now hardcode 'textArea' is in the function. So might be an issue for tabs later if its not one textarea.
  2. Ignore the merge, its just a small change but it works fine.