search

bruin-tennis-consulting / match-manager

A web app for custom tennis match playback, allowing coaches to easily filter and search points by attributes for film review.
https://match-viewing-dashboard.web.app
8 stars 8 forks source link

Upload form updates #185

Closed kesdlvi closed 3 weeks ago

kesdlvi commented 1 month ago

Addresses (1), (3), (6) in issue #182

For (4), I have a script that added a "version" field to the docs in the "UCLA (M)" and "UCLA (W)" collection. I can also add to the "matches" if needed.

For (5), I tested uploading various matches, but since it breaks the site I decided to not keep them in the firebase. I can add them back if needed.

I also commented out the parseMatchScore function, wasn't sure if it is still needed, but it doesn't work on the sets.

awest25 commented 1 month ago

And ideally the website should work with the new format, do you think it would be pretty simple (eg changing how the dates and scores are displayed) or is it a lot more work? If it's just simple naming changes, can you add that to this PR?

awest25 commented 1 month ago

No need to do anything else with the matches collection

awest25 commented 1 month ago

Why is it called "uploadMatchSchemas.js" if it's not uploading any schemas?

kesdlvi commented 1 month ago

The lack of a "name" field was why the site was breaking when a new match was uploaded. I implemented dynamic match name creation to solve this.