brummer10 / Fluida.lv2

Fluidsynth as LV2 plugin
GNU General Public License v2.0
33 stars 4 forks source link

Instruments from MSB 001 onwards are not playable. #23

Closed juancarlangas closed 1 year ago

juancarlangas commented 1 year ago

Let's take as a known example the soundfont GSM-V2.01.sf2, which contains:

- from 000 000 Piano 1 --> 000 127 Gun Shot."

Next we have

- 001 008 Pop Celesta --> 128 064 --SGM Drum Kits--

When we select any sound from this second group, no sound is heard.

imagen

brummer10 commented 1 year ago

Hi Thanks for reporting the issue. I've pushed a fix for it to the repository. Let me know if it works now as expected.

juancarlangas commented 1 year ago

Thank you very much. It works awesome!!!! Very happy with collaborate you and also because it's my first GitHub collaborating issue post.

Be sure I will be in contact since i think Fluida.lv2 will be my selection for huge music creation.

Congratulations!!

juancarlangas commented 1 year ago

I have to reopen the issue because instruments from MSB 001 aren't still playable when session is reloadad

It's true that we could hear the instrument when we select it but if we close the session/DAW and then reload it, the instrument is again unplayable. This affect only MSB 001 onwards instruments.

-Reaper 6.79 -OS: Lubuntu 22.04.2 LTS x86_64 -Host: MacBookPro5,5 1.0 -Kernel: 5.19.0-41-generic -DE: LXQt 1.2.0

brummer10 commented 1 year ago

Ah, I see. Latest commit should fix that as well now.

juancarlangas commented 1 year ago

Congratulations. The program now works perfectly for my use. However, I think the plugin still has unexpected behavior:

So far, if I adjust my musical notes to channel 10 and assign an instrument in Fluida.lv2, when I restart the session/DAW, it goes back to not playing any sound. Could you perform this test? For now, I have to travel and can't do any further testing, but I'll continue to investigate this. If you prefer, I can open a new issue or continue with this one.

brummer10 commented 1 year ago

Yes. I've forgotten to save the channel in the state file, done now. Should be fixed now. Enjoy your journey.

juancarlangas commented 1 year ago

Thank you for the patience, hahaha. In fact, i dont see the issue anymore. So let's close this issue, and I will make another.