brummer10 / Fluida.lv2

Fluidsynth as LV2 plugin
GNU General Public License v2.0
37 stars 5 forks source link

lv2lint check errors for release v0.9 #27

Closed SpotlightKid closed 10 months ago

SpotlightKid commented 10 months ago

When I check the LV2 bundle of version 0.9 with lv2lint, I get the following errors:

$ lv2lint -Mpack -I bin/Fluida.lv2 https://github.com/brummer10/Fluida.lv2

lv2lint 0.16.2
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
<https://github.com/brummer10/Fluida.lv2>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>
    [WARN]  Plugin Author Homepage
              foaf:homepage not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>
  <https://github.com/brummer10/Fluida.lv2#gain>
    [FAIL]  Parameter Range
              lv2:minimum not a float
              seeAlso: <http://lv2plug.in/ns/lv2core#minimum>
  <https://github.com/brummer10/Fluida.lv2#gain>
    [FAIL]  Parameter Range
              lv2:minimum not a float
              seeAlso: <http://lv2plug.in/ns/lv2core#minimum>
  <https://github.com/brummer10/Fluida_gui>
    [FAIL]  UI Symbols
              binary exports superfluous globally visible symbols: 
                * widget_get_scaled_png
                * _draw_combobox_button
                * _xdg_mime_cache_get_mime_type_for_file
                * have_key_in_matrix
                * os_grab_pointer
                * set_pattern
                * _button_released
                * os_is_directory
                * _xdg_mime_magic_get_buffer_extents
                * add_check_button
                * ... there is more, but the rest is being truncated
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>

For the superfluous exported symbols, falkTX has this solution:

https://github.com/DISTRHO/DPF/blob/main/Makefile.plugins.mk#L318

The other error (not sure why it occurs twice) needs to be fixed in Fluida/Fluida.ttl, line 146.

brummer10 commented 10 months ago

Yep, I've forgotten to re-add some compiler flags to the UI after doing the port to windows. should be fixed now with latest commit.

SpotlightKid commented 10 months ago

Confirmed fixed.