search

brummer10 / Mamba

Virtual Midi keyboard and Midi Live Looper for Jack Audio Connection Kit
BSD Zero Clause License
75 stars 5 forks source link

i18n issues (French l10n) #14

Closed trebmuh closed 3 years ago

trebmuh commented 3 years ago

Following #13 , I've build it and so far so good, it seems to work like a charm.

A few possible improvements here to get it perfect!

1. There are some places where the space allocated is too small to handle the French localised strings, such as:

mamba-trans-1 mamba-trans-3

Is there some way from your (coding) side to allow for more space and/or automatic spacing please?

2. One untranslated strings (File -> Load) and one (UTF-8 ?) issue:

mamba-trans-2

3. Clicking the Mapping -> Keymap Editor segfaults when the GUI is in French but displays the Editor if launched in English (LANG=C mamba). No message from the terminal.

That's my current findings.

brummer10 commented 3 years ago

Hi @trebmuh Thanks for your feedback. I could solve most of this issues now. So, the menu is now auto-sized, the labels for the combo boxes get enough space to show the French labels, as well the labels in the file selectors get enough space now and all been marked for translation now. Also the Utf8 issue with the window title is solved. Also the segfault on Mapping -> Keymap Editor in French is solved now. Remaining issues been: I cant give the label on the Knobs and the Record button more space, there simply is no space left in horizontal. Is it possible to use shorts for them? For mnemonic labels (_Label), there is a restriction to 32 chars. This is to keep it all lightweight. Longer ones will be truncate (now, as that is the reason for the segfault). Also for mnemonic labels, the hot keys been hard coded, so when a French label didn't have the char for the hot-key, it may be better to leave the underline alone, instead mark a wrong char.

regards hermann

trebmuh commented 3 years ago

Hey @brummer10 , with your changes and #15, all is good now from my perspectives. I've reverted the hotkeys for now.

trebmuh commented 3 years ago

There seems to be an issue here:

mamba-i18n-issue

What is this "_" character after "Charger MIDI (l)" ?

brummer10 commented 3 years ago

It's were a char underline is replaced with a drawn underline, as most font sets didn't come with underline, so you need to draw it instead using simply the font. Here, my calculation comes to a wrong position for the underline as it should be under the (l), I'll investigate.

trebmuh commented 3 years ago

OK, thanks for the explanation.

Apart from that, it seems all good for me. Is there a 1.4 version planned soon?

brummer10 commented 3 years ago

So I've fixed the issue with the mnemonic labels and pushed a new release out.

trebmuh commented 3 years ago

Awesome. Thanks Hermann!

Closing here then.