search

brummer10 / Mamba

Virtual Midi keyboard and Midi Live Looper for Jack Audio Connection Kit
BSD Zero Clause License
75 stars 5 forks source link

Mamba closes/stops in non-session-manager instead of hiding it's GUI #43

Closed grammoboy2 closed 2 years ago

grammoboy2 commented 2 years ago

When I close mamba from it's own gui, while running in non-session-manager, it ... closes/stops. But I think it would be better if it would hide in that case when under nsm and let the user use the nsm gui to stop it.

brummer10 commented 2 years ago

I know there are a couple of assumptions about how a client under NSM control should behave. But, I like to revert this to the user. If you would control Mamba from the NSM GUI, just do that, all options been supported. If not, use the controls Mamba provide (and be ensured that Mamba forward this info to the NSM controller). Still, even when you've quit Mamba from it's internal menu, you are able to restart it from the NSM controller. If you only would hide Mamba, just do it from the NSM controller.

grammoboy2 commented 2 years ago

Hm hiding the gui is a more common/regular action then stopping Mamba in a session. So hiding instead of closing, prevents the user from switching back and forth from nsm gui to applications. If you want to keep this a user choice, you could maybe add a configuration option, compile option or environment variable.

brummer10 commented 2 years ago

Okay, so I've implemented your request. Still, when will show the UI again, you've to use the NSM GUI anyway, so the difference is just marginal. The desktop decorator (x) still close the app.