Mamba fails to build on Fedora 38

[plaimbock]

Hi, thank you for Mamba! I just tried to build git HEAD on Fedora 38 x86_64 and the build fails with:

XAlsa.cpp: In member function 'void xalsa::XAlsa::xalsa_get_ports(std::vector<std::cxx11::basic_string >, std::vector<std::__cxx11::basic_string >)': XAlsa.cpp:157:34: error: no matching function for call to 'std::vector<std::cxx11::basic_string >::push_back(char [256])' 157 | iports->push_back(port); | ~~~^~~~

Any idea how to solve this error?

[brummer10]

Hi Thanks for reporting. I've pushed a fix for it to the repository. Let me know if it works for you.

[plaimbock]

Thanks for the quick reply! Commit 05aafdb results in a different error (see attachment). mamba_build_errors.txt

[brummer10]

Strange, never seen such a error, mean error: aggregate 'std::string p' has incomplete type and cannot be defined doing so for years defining empty std::strings without issues. Which gcc version do you use? However, I've pushed a other try, maybe that works on your setup.

[plaimbock]

No joy. The gcc version is 13.0.1. The build log with the errors is at: https://download.copr.fedorainfracloud.org/results/patrickl/Mamba/fedora-38-x86_64/05808875-mamba/builder-live.log.gz

[brummer10]

Okay. It looks like gcc 13 now requires explicit including string header.
Before I push a other try could you try to edit XAlsa.h and add #include <string> right below #include line 23 if that works I'll push the fix to the repository.

according to here: https://gcc.gnu.org/gcc-13/porting_to.html

[plaimbock]

That works!

Successful build log here: https://download.copr.fedorainfracloud.org/results/patrickl/Mamba/fedora-38-x86_64/05808962-mamba/builder-live.log

[brummer10]

Okay, nice. So I've added that in the repository as well.