search

brummer10 / XUiDesigner

A WYSIWYG LV2 GUI/plugin creator tool
BSD Zero Clause License
100 stars 3 forks source link

Fix uninitializes ports, fix missing bracket #18

Closed dehnhardt closed 1 year ago

dehnhardt commented 1 year ago

I tried to generate a project from a json gui file. However, there were two problems: 1) The ports in line 95 were not initializes because the designer was not set to 'is_project'. In my opinion, it makes no difference here, if it was a json file or a designer project as all information from json should have been added to the project. But I don't know, if the designer->is_project member is needed elsewhere as is, therefore I introduced a local variable. 2) In Line 485 a condition is opened when the lv2 bypass is present. This was never closed.

brummer10 commented 1 year ago

Hi @dehnhardt

Many thanks for your pull request. I hope you don't mind, but I've to cherry pick from it because the missing bracket is only true when parse_file is false so we need to put that under this condition. Using a local variable for is_project is fine, so I've take that as it is.

Still be aware that we miss the information for audio and midi ports from the json file so you must set them in the settings dialogue before you save the bundle. The json file contain plain UI informations as it is meant to allow to rework the UI anytime later, or using a other UI toolkit which could read the json.

So I'll close this pull request now. regards hermann

dehnhardt commented 1 year ago

I hope you don't mind, but I've to cherry pick

Of course not!

Still be aware that we miss the information for audio and midi ports from the json file so you must set them in the settings dialogue before you save the bundle. The json file contain plain UI informations as it is meant to allow to rework the UI anytime later, or using a other UI toolkit which could read the json.

I changed this locally (as I found it boring to add it over and over again in the dialog) but was not sure if this is intended. Now I know it's not. ;-) Would it make sense to add another json file to carry that information if wanted? Holger

brummer10 commented 1 year ago

a additional json file will make it more complicated, but, it wouldn't harm to add those infos to the current file. I just haven't add them because for the use-case I had in mind it wasn't needed. patches been welcome. regards hermann