brummer10 / XUiDesigner

A WYSIWYG LV2 GUI/plugin creator tool
BSD Zero Clause License
100 stars 3 forks source link

Build failure on Fedora #21

Closed ycollet closed 7 months ago

ycollet commented 7 months ago

While trying to build XUIDesigner on Fedora, I met a compilation error related to a wrongly formatted config.h:

./config.h:1:15: warning: extra tokens at end of #ifdef directive
    1 | #ifdef USE_LD \n#undef USE_LD \n#endif
      |               ^
./config.h:1: error: unterminated #ifdef
    1 | #ifdef USE_LD \n#undef USE_LD \n#endif
      | 
make[2]: *** [Makefile:168: b64_encode.o] Error 1
brummer10 commented 7 months ago

what shell do you use? Usually the \n token will be interpreted as new line ( and not printed as "\n" by the echo command writing the config.h file.

ycollet commented 7 months ago

I use bash.

ycollet commented 7 months ago

I think the echo command needs the "-e" parameter to interpret all backslashed characters.

ycollet commented 7 months ago
$ echo "test \n"
test \n
$ echo -e "test \n"
test 
brummer10 commented 7 months ago

Using bash here as well. echo -e behave un consistent across versions, hence I decided for plain echo, but that seems to be affected from versions differences as well. I guess I'll simply split it into 3 echos to ensure it works across versions. Thanks for reporting, I'll fix it.

ycollet commented 7 months ago

Thanks for all the work you make !

brummer10 commented 7 months ago

It's done now. Latest git version should build fine now regardless the echo version in use. greets hermann

ycollet commented 7 months ago

Build fine now. I close the ticket ! Thanks !