clang warnings

[yurivict]

XUiColorChooser.c:454:17: warning: taking the absolute value of unsigned type 'unsigned long' has no effect [-Wabsolute-value]
            if (abs(((pixel >> 0x10) & 0xFF) - _R) < 2 &&
                ^
XUiColorChooser.c:454:17: note: remove the call to 'abs' since unsigned values cannot be negative
            if (abs(((pixel >> 0x10) & 0xFF) - _R) < 2 &&
                ^~~
XUiColorChooser.c:455:17: warning: taking the absolute value of unsigned type 'unsigned long' has no effect [-Wabsolute-value]
                abs(((pixel >> 0x08) & 0xFF) - _G) < 2 &&
                ^
XUiColorChooser.c:455:17: note: remove the call to 'abs' since unsigned values cannot be negative
                abs(((pixel >> 0x08) & 0xFF) - _G) < 2 &&
                ^~~
XUiColorChooser.c:456:17: warning: taking the absolute value of unsigned type 'unsigned long' has no effect [-Wabsolute-value]
                abs((pixel & 0xFF) - _B) < 2 ) {
                ^
XUiColorChooser.c:456:17: note: remove the call to 'abs' since unsigned values cannot be negative
                abs((pixel & 0xFF) - _B) < 2 ) {
                ^~~
3 warnings generated.
XUiDesigner.c:1286:71: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
            asprintf(&designer->controls[designer->wid_counter].name, label);
                                                                      ^~~~~
XUiDesigner.c:1286:71: note: treat the string as an argument to avoid this
            asprintf(&designer->controls[designer->wid_counter].name, label);
                                                                      ^
                                                                      "%s",
1 warning generated.
XUiGenerator.c:190:16: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
        printf(cmd);
               ^~~
XUiGenerator.c:190:16: note: treat the string as an argument to avoid this
        printf(cmd);
               ^
               "%s",
XUiGenerator.c:517:24: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
                printf(cmd);
                       ^~~
XUiGenerator.c:517:24: note: treat the string as an argument to avoid this
                printf(cmd);
                       ^
                       "%s",
XUiGenerator.c:593:144: warning: more '%' conversions than data arguments [-Wformat-insufficient-args]
                    asprintf(&cmd, "cd %s && echo 'const char* %s = \"'| tr -d '\r\n' > %s && base64 %s | tr -d '\r\n' >> %s && echo '\";' >> %s", filepath, xldv, xldc, xldl, xldc);
                                                                                                                                              ~^
XUiGenerator.c:651:152: warning: more '%' conversions than data arguments [-Wformat-insufficient-args]
                            asprintf(&cmd, "cd %s && echo 'const char* %s = \"'| tr -d '\r\n' > %s && base64 %s | tr -d '\r\n' >> %s && echo '\";' >> %s", filepath, xldv, xldc, xldl, xldc);
                                                                                                                                                      ~^
4 warnings generated.

[brummer10]

Hi @yurivict Thanks for the report. I've fixed them all within the latest commit. regards hermann

[yurivict]

Thanks!