brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
263 stars 29 forks source link

guitarix don't compile with zita-resampler 1.10 #122

Closed styrsven closed 1 year ago

styrsven commented 1 year ago

zita-resampler.py identifies the version of zita-resampler by checking that ZITA_RESAMPLER_MAJOR_VERSION has the value 1, but in version 1.10 ZITA_RESAMPLER_MAJOR_VERSION is not defined in the include files.

brummer10 commented 1 year ago

Hi Thanks for reporting the issue. I haven't checked out zita-resampler 1.10 for now. Still, as we provided zita-resampler included in the source there is no reason to fail at this step. So now, when the zita-resampler test fail we'll switch to use the internal version instead refuse compile. At some point later I'll implement a check for >1.10