brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
234 stars 24 forks source link

Out of sync with Sourceforge git #123

Closed Rippert closed 4 months ago

Rippert commented 1 year ago

I just updated Guitarix-git from the AUR, which pulls from the Sourceforge git repository. I had thought that your GitHub and Sourceforge repositories are automatically synced, but the latest commit from Sourceforge is [b1c686] Fix issue #110 GxTuner Issues from 2022-05-26.

If you are not keeping the repositories in sync anymore, you might want to inform @gimmeapill so he can change the Guitarix-git pkgbuild file.

brummer10 commented 1 year ago

Hi @Rippert I'm sorry, didn't know that the AUR-git package fetch from sourceforge. That should indeed switch to github. As you've ping him here, it should happen soon.
At some point I'll sync the repository's again, but for now I'm focusing on the guitarix.vst version. https://github.com/brummer10/guitarix.vst Syncing was all time done by hand by me, but the github repository is the main development platform.

Rippert commented 1 year ago

Thanks Hermann. I did get the pkgbuild file to work by just changing the download URL from sourceforge to your Github repo.

I've heard about your VST version. Sounds cool. I'll try it out here soon.

Rippert commented 1 year ago

close

Rippert commented 1 year ago

I can't seem to close this issue even though I opened it.

brummer10 commented 1 year ago

Hi @Rippert Let's just keep it open as a reminder for me that I need to sync the repositories before the next release. Have you seen the new factory presets, there are some special for bass, what do you think of them?

Rippert commented 1 year ago

Yes, the new presets are why I wanted to update. Just played with them for a short time earlier today. Really nice.

A couple of the Bass presets use the Bass enhancer more than I like, but I have pretty good subwoofers and they are probably set up for studio monitors.

Still, really nice overall. Very good levels and tone. Some of the guitar presets work well for Bass too.

It looks like there are a bunch of new "factory" impulse files in the band folder too, unless I just missed them in my last update. Some really nice sounds. A little hard to tell what to expect from them from the names of the bands but a really good variety to play with. The "Slap" preset uses the convolution plugin and playing with the different files in the band folder gives some really good sounds. They did a good job with the other plugins, the Quad filter, the graphic EQ and the Bright enhancer (don't have the right names in front of me). Really makes the string harmonics pop out. I'll be using that one as a basis for some new custom presets.

Have you ever thought of including a folder of speaker impulses? I know there is a plugin that does some of that, but there are so many possible speakers and it's a little easier to guess what to expect from them from the name of the speaker. I've been using a generic 8x10 impulse on some of my custom presets and it sounds pretty good through a full range PA with a subwoofer.

Gimmeapill commented 1 year ago

Thanks guys, I'll update the pkgbuild over the week end (and check also those new presets)

brummer10 commented 1 year ago

A couple of the Bass presets use the Bass enhancer more than I like

That was my impression as well. But nice to hear you like them anyway. So do I.

It looks like there are a bunch of new "factory" impulse files in the band folder too

No, they are there since ages. Just maybe not so prominent, I know that most people oversee them. Within the new vst version they been implemented more prominent.

Have you ever thought of including a folder of speaker impulses?

Sure, just it isn't easy to find IR-files under a free license. For the implemented ones by David Fau Casquel, he gives me permission to distribute them under the GPL, I can't find any other IR files which are clearly licenced under a comparable, free license. (Most freebies comes with a restricted, or without any license, so that wouldn't work properly). Other IR-file creators I asked wouldn't go the full GPL route.

Gimmeapill commented 1 year ago

pkgbuild updated

Gimmeapill commented 1 year ago

Regarding the presets:

0EVSG commented 1 year ago

Please update the README.md if packagers should switch to github - it's not obvious with it currently declared a mirror of sourceforge.

brummer10 commented 1 year ago

If you package releases, you could stay at sourceforge as well. I'll sync the repositories before doing a release. Only when you provide development snapshots you should point to github, as currently development is going on on github exclusive.

Gimmeapill commented 1 year ago

This is absolutely ok: there is nowadays a well maintained official package of the latest stable release in Arch. I just checked and it fetches the code from Sourceforge. Mine is just to track the latest development, so github is indeed the way to go.

0EVSG commented 1 year ago

If you package releases, you could stay at sourceforge as well. I'll sync the repositories before doing a release.

Good to know, thanks for the clarification. In my case I was looking to backport the build fix 53560efbbc44a971b7b10290d96b059b67c71eed for #122, and couldn't find the commit on sourceforge - so I still think the README can be a bit misleading. Not a big issue though.

brummer10 commented 4 months ago

I've marked guitarix on Sourcforge now as obsolete and point to github