search

brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
234 stars 24 forks source link

Declick it - knob position changes cause clicks #140

Closed EsGeh closed 3 months ago

EsGeh commented 4 months ago

Problem

Some plugins cause clicks when a knob is changed while there is an input signal.

Example

Cabinet: Bass, Treble, and Level knob.

Explanation

It feels very unprofessional.

Solution

Maybe it's enough to lowpass / dampen the knob value signal in order to smoothen the changes. Alternatively, depending on the actual DSP, it might be necessary to crossfade into the "dry" signal when knob position is changed and back to the "wet" signal afterwards.

brummer10 commented 4 months ago

Hi Yep, that was bad by design. I've now fixed that. Latest commit fix the cabinet and amp-impulse plugs to avoid any clicks on the knobs. Let me know please if you've found more knobs with this issue.