search

brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
263 stars 29 forks source link

Compiling from master fails since implementing NAM #142

Closed Gnatzelle closed 7 months ago

Gnatzelle commented 7 months ago

Compiling from master fails since commit: https://github.com/brummer10/guitarix/commit/30be767f37e07a69605dfe128012c783553c97a0

/usr/bin/ld: src/NAM/libnam.a(dsp.cpp.1.o): plugin needed to handle lto object /usr/bin/ld: src/NAM/libnam.a(dsp.cpp.1.o): plugin needed to handle lto object /usr/bin/ld: src/NAM/libnam.a(get_dsp.cpp.1.o): plugin needed to handle lto object /usr/bin/ld: src/NAM/libnam.a(get_dsp.cpp.1.o): plugin needed to handle lto object /usr/bin/ld: src/gx_head/engine/gx_internal_plugins.cpp.1.o: in function gx_engine::NeuralAmp::load_nam_file()': gx_internal_plugins.cpp:(.text+0xf4c4): undefined reference tonam::get_dsp(std::filesystem::__cxx11::path)' /usr/bin/ld: gx_internal_plugins.cpp:(.text+0xf5d2): undefined reference to `nam::DSP::GetLoudness() const'

and

File "/usr/bin/waf", line 168, in Scripting.waf_entry_point(cwd, VERSION, wafdir) File "/lib/python3.11/site-packages/waf/waflib/Scripting.py", line 159, in waf_entry_point run_commands() File "/lib/python3.11/site-packages/waf/waflib/Scripting.py", line 255, in run_commands ctx = run_command(cmd_name) File "/lib/python3.11/site-packages/waf/waflib/Scripting.py", line 239, in run_command ctx.execute() File "/lib/python3.11/site-packages/waf/waflib/Scripting.py", line 588, in execute return execute_method(self) File "/lib/python3.11/site-packages/waf/waflib/Build.py", line 231, in execute self.execute_build() File "/lib/python3.11/site-packages/waf/waflib/Build.py", line 251, in execute_build self.compile() File "/lib/python3.11/site-packages/waf/waflib/Tools/errcheck.py", line 192, in check_compile ret = self.orig_compile() File "/lib/python3.11/site-packages/waf/waflib/Build.py", line 355, in compile raise Errors.BuildError(self.producer.error) File "/lib/python3.11/site-packages/waf/waflib/Errors.py", line 46, in init WafError.init(self, self.format_error())`

OS is an up-to-date Arch Linux. Also tired to install the NAM LV2-Plugin from the AUR but that doesn't helped either :/

brummer10 commented 7 months ago

Looks like you missing some submodule. What command do you use to configure/build? please try the latest master with

git clone https://github.com/brummer10/guitarix.git
cd guitarix
git submodule update --init --recursive
cd ./trunk
./waf configure --prefix=/usr  --includeresampler --includeconvolver --optimization
./waf build
brummer10 commented 7 months ago

Ah, wait, I remember now that arch requires the -flto compiler flag. Using this I could reproduce your issue. I'll fix it and send a message here.

brummer10 commented 7 months ago

Okay, should be fixed now. Please pull from the latest master

Gnatzelle commented 7 months ago

Thank you for the very quick fix brummer, it's building again :)

And sorry if my Issue-Report was a bit rude. I was in a hurry and didn't want to forget to report it again >.<

brummer10 commented 7 months ago

You are welcome. Your report was straight to the point, very welcome.