search

brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
234 stars 24 forks source link

0.45.0: Source tarball packs files top-level #143

Closed dvzrv closed 4 months ago

dvzrv commented 4 months ago

Hi! :wave:

When trying to build 0.45.0 I noticed that the source tarball no longer provides the files in a top-level directory (e.g. guitarix-0.45.0) when extracting, but just top-level.

For people building from source this is really quite messy and an anti-pattern as everything below the trunk/ dir is just extracted to the current working directory!

Can this please be changed for any upcoming release again? :)

brummer10 commented 4 months ago

Yep, sorry. I need to rewrite the ./waf dist class in order to implement the now needed submodule. Unfortunately the top directory get lost by that. I'll fix that. Thanks for the head up

dvzrv commented 4 months ago

Thanks! Will just build top-level for the time being :)